Create Django templatetags #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archmonger
changed the title
|
@rmorshea Let's schedule something out this weekend to discuss this. |
|
Also heads up, |
attempt re-adding tag stuff styling fix
Archmonger
force-pushed
the
add_template_tags
branch
from
6b2afd2 to
8b0b363
Compare
|
@Archmonger how about Sunday at 11am? |
Sounds good |
|
closing in favor of #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Barebones structure to allow for a user to simply type
to import IDOM into Django.
note: these template tags are only registered if the user adds "django_idom" to
settings.py:INSTALLED_APPSAs I mentioned, there is gonna be some slight awkwardness to this due to build.js not being built directly to
django_idom/static/js/idom.js. However, that can be resolved via modifying our deployment procedure.I've included some HTML and JS comments just for our sake. We'll remove them before we merge this PR.
Alternatively, we can have
idom.jspoint to JavaScript stored on a CDN somewhere rather than locally deploying. But, many Django users due prefer local files due to things such asDjango-CompressorandDjango-Pipelinesthough.